Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/nlohmann/json/issues/1387 #1389

Closed
wants to merge 2 commits into from
Closed

Fixes https://github.com/nlohmann/json/issues/1387 #1389

wants to merge 2 commits into from

Conversation

pratikpc
Copy link
Contributor

@pratikpc pratikpc commented Dec 9, 2018

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
In #1387, a user was facing difficulty because he was using map class.
Map class sorts it's elements on the basis of < function by default.
Now this meant that the bug existed in inline bool operator< defined at value_t.hpp

If you are to look at the Numerics Mentioned beside the comment in the previous code base, you would find that they do not match the one mentioned/implied in enum class value_t
The correction of these values fixes the issue altogether

Further I carried out a small modification to the .gitignore file so that it starts ignoring Visual Studio IDE auto-generated files( which I used).
Should I delete the .gitignore modification?


Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
  • Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

In #1387, a user was facing difficulty because he was using map class.
Map class sorts it's elements on the basis of < function.
Now this meant that the bug existed in inline bool operator<
If you are to look at the Numerics Mentioned beside the comment in the previous code base, you would find that they do not match the one mentioned/implied in enum class value_t
The correction of these values fixes the issue altogether
@pratikpc
Copy link
Contributor Author

pratikpc commented Dec 9, 2018

Broke a few tests,
Considering #1387 am not sure, if this is a bug or a feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant